gen_stub: support use statements in stub files#21784
Merged
DanielEScherzer merged 1 commit intophp:masterfrom Apr 17, 2026
Merged
gen_stub: support use statements in stub files#21784DanielEScherzer merged 1 commit intophp:masterfrom
DanielEScherzer merged 1 commit intophp:masterfrom
Conversation
GromNaN
force-pushed
the
fix-gen-stub-use-statements
branch
from
271a897 to
7296cf9
Compare
GromNaN
force-pushed
the
fix-gen-stub-use-statements
branch
from
7296cf9 to
7a158af
Compare
iluuu1994
approved these changes
Apr 17, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Seems harmless. But @kocsismate should merge as he's codeowner.
GromNaN
force-pushed
the
fix-gen-stub-use-statements
branch
from
7a158af to
0e10d2e
Compare
Member
|
Sorry, please rebase your branch, I've just merged your other PR :) |
Stmt\Use_ and Stmt\GroupUse nodes were not handled in handleStatements(), causing an "Unexpected node" exception when use statements appeared in stub files. Since NameResolver resolves all names to their fully qualified form before handleStatements() runs, these nodes can simply be skipped.
GromNaN
force-pushed
the
fix-gen-stub-use-statements
branch
from
0e10d2e to
029343e
Compare
Member
Author
|
PR rebased. The conflict was bound to happen. |
DanielEScherzer
approved these changes
Apr 17, 2026
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Looks good to me, leaving to @kocsismate for final approval
kocsismate
approved these changes
Apr 17, 2026
Member
|
I'm leaving for sleep, so anyone can feel free to merge it once the tests pass. I can do it in the morning :) |
Member
I can handle merging since this looks good to you |
arshidkv12
pushed a commit
to arshidkv12/php-src
that referenced
this pull request
Apr 18, 2026
Stmt\Use_ and Stmt\GroupUse nodes were not handled in handleStatements(), causing an "Unexpected node" exception when use statements appeared in stub files. Since NameResolver resolves all names to their fully qualified form before handleStatements() runs, these nodes can simply be skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in
build/gen_stub.php:useanduse groupstatements in stub files caused an"Unexpected node Stmt_Use"exception. SinceNameResolveralready resolves names to their fully qualified form beforehandleStatements()runs, these nodes can be skipped.